Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider: Support default tags (resources aws_w) #18741

Merged
merged 1 commit into from
Apr 21, 2021
Merged

provider: Support default tags (resources aws_w) #18741

merged 1 commit into from
Apr 21, 2021

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Apr 11, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #7926

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Notes

  • verified data-sources in this w group either set tags explicitly or do not have "tags" in the schema nor share a resource's read method

@anGie44 anGie44 requested a review from a team as a code owner April 11, 2021 22:21
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/waf Issues and PRs that pertain to the waf service. service/wafv2 Issues and PRs that pertain to the wafv2 service. service/workspaces Issues and PRs that pertain to the workspaces service. labels Apr 11, 2021
@anGie44 anGie44 force-pushed the f-default-tags-support-w-resources branch 2 times, most recently from 22b9e5c to 5e922d3 Compare April 11, 2021 23:43
@anGie44 anGie44 force-pushed the f-default-tags-support-w-resources branch from 5e922d3 to 93bb2e4 Compare April 12, 2021 01:07
@ewbankkit ewbankkit self-assigned this Apr 21, 2021
ewbankkit
ewbankkit approved these changes Apr 21, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@anGie44 anGie44 added this to the v3.38.0 milestone Apr 21, 2021
@anGie44 anGie44 merged commit 004d2ef into main Apr 21, 2021
@anGie44 anGie44 deleted the f-default-tags-support-w-resources branch April 21, 2021 18:25
@ghost
Copy link

ghost commented Apr 30, 2021

This has been released in version 3.38.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
documentation Introduces or discusses updates to documentation. service/waf Issues and PRs that pertain to the waf service. service/wafv2 Issues and PRs that pertain to the wafv2 service. service/workspaces Issues and PRs that pertain to the workspaces service. size/XL Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v3.38.0
Development

Successfully merging this pull request may close these issues.
2 participants
@anGie44 @ewbankkit